[#4478] New notes model and admin controller #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethrees
reviewed
Aug 10, 2022
This adds admin route helpers for `PublicBody` and `InfoRequest` so we can call: 1. `admin_public_body_path(...)` -> `/admin/bodies/123` 2. `admin_info_request_path(...)` -> `/admin/requests/123` 3. `url_for([:admin, public_body_or_info_request])` and the correct route returned. This will be helpful for redirecting after creating/updating notes for a given record.
Instead of needing a `HasTagString::HasTagStringTag` instance this commit changes the helper to also accept a text string. Will correctly link and style the string tag with name/value to the tag admin controller. As this doesn't include the `model_type` so the tag controller will assume `PublicBody` which is fine and a good assumption to make.
This is the start of #4478
Adds an association as `Notable#concrete_notes` to avoid clashing with the current `PublicBody#notes` column. This uses a polymorphic association so any model can be `Notable`.
garethrees
reviewed
Aug 11, 2022
garethrees
reviewed
Aug 24, 2022
| @@ -485,6 +485,22 @@ | |||
| end | |||
| #### | |||
|
|
|||
| #### AdminNote controller | |||
There was a problem hiding this comment.
be nicer to have shallow routes for new so that we can do e.g. /admin/bodies/3/notes/new (which automatically sets notable_type & notable_id), but then editing the created note is simply /admin/note/:id/edit. not essential this minute though
This was referenced Aug 26, 2022
Merged
garethrees
approved these changes
Aug 26, 2022
Allow notes to be created with an association to tags via a `Note#notable_tag` column. This updates `Notable#all_notes` to combine concrete and tagged notes. Fixes #6994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #4478
Fixes #6994
What does this do?
Adds new notes model and admin controller. Associated as a "concrete note" with
PublicBodyvia a newNotableconcern. Also can be assoicated as a "tagged note" via anotable_tagcolumn.Why was this needed?
Easier handling of notes, especially via tags, so notes don't need to be manually added to multiple authorities.
Implementation notes
Have extract out these new issues from #4478
PublicBody#notestoNotemodel #7216PublicBodyimport #7217PublicBodyXapian indexing for notes #7218These will be done as separate PRs.
Screenshots
Notes to reviewer